Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeed (ticdc): remove status of a changefeed after it is removed #9174

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Jun 12, 2023

What problem does this PR solve?

Issue Number: close #9173 #9177

What is changed and how it works?

Delete the status metric of a changefeed when it is removed.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 12, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 12, 2023
@asddongmen asddongmen added the status/ptal Could you please take a look? label Jun 12, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 12, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 12, 2023
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed lgtm labels Jun 12, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 12, 2023
@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, nongfushanquan, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 12, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-12 03:23:06.093713225 +0000 UTC m=+122735.548474586: ☑️ agreed by sdojjy.
  • 2023-06-12 03:29:17.106218591 +0000 UTC m=+123106.560979886: ☑️ agreed by nongfushanquan.
  • 2023-06-12 03:53:10.11145119 +0000 UTC m=+124539.566212641: ✖️🔁 reset by asddongmen.
  • 2023-06-12 03:54:33.259297508 +0000 UTC m=+124622.714058812: ☑️ agreed by sdojjy.
  • 2023-06-12 04:04:51.946911466 +0000 UTC m=+125241.401672769: ☑️ agreed by 3AceShowHand.

@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #9182.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 12, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9183.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 12, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9184.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status of Deleted Changefeeds in Grafana Dashboard
5 participants